Avoid auth configuration for submodules when settings.submodules is false ( rebased #424 ) auth submodules #1321
+18
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help with actions#354. The problem is that I have no idea whether such auth submodules configuration is required even when settings.submodules is false.
This reverts commit c764e5e.
Error: Unstaged changes detected. Locally try running: git clean -ffdx && npm ci && npm run format && npm run build Error: Process completed with exit code 1. Rebased PR from actions#424
kaidokert
force-pushed
the
users/cosimo/issue-354-auth-submodules
branch
from
9a48990
to
1bf7689
Compare
kaidokert
changed the title
kaidokert
changed the title
kaidokert
added a commit
to youtube/cobalt
that referenced
this pull request
May 16, 2023
This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. Upstream PR: actions/checkout#1321 b/282361986 b/258687270
cobalt-github-releaser-bot
pushed a commit
to youtube/cobalt
that referenced
this pull request
May 16, 2023
This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. Upstream PR: actions/checkout#1321 b/282361986 b/258687270 (cherry picked from commit 3c24834)
kaidokert
added a commit
to youtube/cobalt
that referenced
this pull request
May 16, 2023
…386) This switches Windows workers, which are not yet ephemeral to use a patched version of checkouts. This guarantees always cleaning up repo state even in case of previous bad submodules-like repo operations done by a previous run. In the long run, we should be using ephemeral workers, and switch to upstream fixed version if the PR gets merged upstream. Upstream PR: actions/checkout#1321 b/282361986 b/258687270 (cherry picked from commit 3c24834) Co-authored-by: Kert <[email protected]>
Spiritaine
approved these changes
May 17, 2023
andrewsavage1
approved these changes
May 20, 2023
|
Hoping we can get this landed soon, it's giving our project a number of issues |
Kaminem2021
approved these changes
May 28, 2023
Spiritaine
approved these changes
May 30, 2023
Spiritaine
approved these changes
Jul 9, 2023
|
Another ping for review, please |
|
@cory-miller can we get this reviewed/merged? |
|
@joshmgross is there something that needs to be done to get this reviewed? Fwiw, I see it here: I'll probably consider carrying this PR in a fork of actions/checkout until it's merged... |
|
Another ping for review, please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased #424 to try to get this landed.
Fixes #354 #1582